-
Notifications
You must be signed in to change notification settings - Fork 349
feat(query): implements "Beta - SQL DB Instance With Unrecommended Logging Threshold" #7782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a quality of life change, if you agree with my suggestion. Rather than that, looks good to me.
assets/queries/terraform/gcp/sql_db_instance_with_unrecommended_logging_threshold/metadata.json
Outdated
Show resolved
Hide resolved
…re_that_the_'log_min_messages'_database_flag_for_cloud_sql_postgresql_instance_is_set_at_minimum_to_warning
…16626_13_6.2_PostgreSQL_Database_ensure_that_the_'log_min_messages'_database_flag_for_cloud_sql_postgresql_instance_is_set_at_minimum_to_warning
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21271469 | Triggered | Generic Password | 45d88e7 | assets/queries/terraform/azure/unrestricted_sql_server_access/test/negative4.tf | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…re_that_the_'log_min_messages'_database_flag_for_cloud_sql_postgresql_instance_is_set_at_minimum_to_warning








Reason for Proposed Changes
Currently there is no query to ensure that a "google_sql_database_instance" resource with a "POSTGRES" based "database_version" has the 'log_min_messages' flag set to the severity threshold of "WARNING" or higher.
Quoting CIS_Google_Cloud_Platform_Foundation_Benchmark_v4.0.0 page 229: "
Auditing helps in troubleshooting operational problems and also permits forensic analysis. If log_min_messages is not set to the correct value, messages may not be classified as error messages appropriately. Setting the threshold to 'Warning' will log messages for the most needed error messages."Proposed Changes
warningor higher:"WARNING"|"ERROR"|"LOG"|"FATAL"|"PANIC"(default value is ERROR)Tenable reference
I submit this contribution under the Apache-2.0 license.